-
Notifications
You must be signed in to change notification settings - Fork 6k
Update Hub + Landing pages to prep for L2 removal #18024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the download sdk URI
BillWagner
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @wadepickett
I looked at the other landing pages for consistency with what we've done on other landing pages and made a couple suggestions. Once you decide what to do, let's
tdykstra
reviewed
Apr 23, 2020
gewarren
reviewed
Apr 23, 2020
Co-Authored-By: Tom Dykstra <[email protected]>
Per review suggestion, added linkListType: download for download sdk link.
Per review suggestion: Added proper download linktype to download sdk link
Per review suggestion: added linklist type of download for download sdk link.
Per review suggestion: Moved Community into its own section.
fixed yaml formatting error at new community sections
gewarren
reviewed
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates part 1 for #18011
Internal Review - Hub
Internal Review - Framework Landing Page
Internal Review - Standard Landing Page
Internal Review - What's New
Internal Review - Visual Basic Landing Page
Hub page:
What's New page:
.NET Framework landing page:
.NET Standard landing Page:
What's New page:
The L2 itself will be removed in a separate PR once these changes are merged.