Skip to content

Conversation

wadepickett
Copy link
Contributor

@wadepickett wadepickett commented Apr 23, 2020

PR updates part 1 for #18011

Internal Review - Hub
Internal Review - Framework Landing Page
Internal Review - Standard Landing Page
Internal Review - What's New
Internal Review - Visual Basic Landing Page

Hub page:

  • Add Download .NET highlight card to top left.
  • Add a "Community" link plus a .NET Foundation link to the open source card

What's New page:

  • Add a “Community” link to the “Get Involved” card.

.NET Framework landing page:

  • Add link to .NET Download on "Install .NET Framework section"

.NET Standard landing Page:

  • Add link to .NET Download as first link in Learn about .NET section

What's New page:

  • Add Community and .NET Foundation links to "Get involved - contribute" section.

The L2 itself will be removed in a separate PR once these changes are merged.

@wadepickett wadepickett self-assigned this Apr 23, 2020
@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 23, 2020
@wadepickett wadepickett requested review from BillWagner and removed request for BillWagner April 23, 2020 02:46
Fixed the download sdk URI
@wadepickett wadepickett marked this pull request as ready for review April 23, 2020 03:16
@wadepickett wadepickett removed request for a team, KathleenDollard and gewarren April 23, 2020 03:17
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @wadepickett

I looked at the other landing pages for consistency with what we've done on other landing pages and made a couple suggestions. Once you decide what to do, let's :shipit:

wadepickett and others added 6 commits April 23, 2020 10:45
Per review suggestion, added linkListType: download for download sdk link.
Per review suggestion:  Added proper download linktype to download sdk link
Per review suggestion: added linklist type of download for download sdk link.
Per review suggestion: Moved Community into its own section.
fixed yaml formatting error at new community sections
@wadepickett wadepickett merged commit 6aa84c0 into master Apr 23, 2020
@wadepickett wadepickett deleted the wade-pickett/updates-4-22 branch April 23, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants